Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modernize linters #4642

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Modernize linters #4642

wants to merge 11 commits into from

Conversation

eapolinario
Copy link
Contributor

Tracking issue

NA

Why are the changes needed?

In an effort to modernize the use of linters in the codebase we first unify the config file used across the projects.

What changes were proposed in this pull request?

A few changes:

  • A single .golangci.yml file is shared across all repos
  • The separate CI checks to check for lint errors now run in a single step

How was this patch tested?

Setup process

Screenshots

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

Docs link

@eapolinario
Unify .golangci.yml
9bbf84a 
Signed-off-by: Eduardo Apolinario <[email protected]>
@eapolinario
Run make lint-all
d63c947 
Signed-off-by: Eduardo Apolinario <[email protected]>
@eapolinario
Remove deprecated linters
e6e73cf 
Signed-off-by: Eduardo Apolinario <[email protected]>
@eapolinario
Remove golint in favor of revive
bc2ec4b 
Signed-off-by: Eduardo Apolinario <[email protected]>
@eapolinario
Remove unused exception
d2a1ff6 
Signed-off-by: Eduardo Apolinario <[email protected]>
@eapolinario
Lint all files in a single step
22da231 
Signed-off-by: Eduardo Apolinario <[email protected]>
@dosubot dosubot bot added size:XL This PR changes 500-999 lines, ignoring generated files. enhancement New feature or request housekeeping Issues that help maintain flyte and keep it tech-debt free labels Dec 26, 2023
@eapolinario
Specify runs-on
547da77 
Signed-off-by: Eduardo Apolinario <[email protected]>
@eapolinario
Add checkout and setup go steps
dd0671e 
Signed-off-by: Eduardo Apolinario <[email protected]>
@codecov Codecov
Copy link

codecov bot commented Dec 26, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0e35cab) 59.03% compared to head (9ac145c) 58.11%.
Report is 2 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #4642      +/-   ##
==========================================
- Coverage   59.03%   58.11%   -0.92%     
==========================================
  Files         622      626       +4     
  Lines       52823    53815     +992     
==========================================
+ Hits        31182    31277      +95     
- Misses      19150    20036     +886     
- Partials     2491     2502      +11
Flag Coverage Δ
unittests 58.11% <ø> (-0.92%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hamersaw
Copy link
Contributor

hamersaw commented Jan 2, 2024

Does this only work with make -C <component> lint from the flyte repo root? or does it still work using make lint from each internal project (ex. cd ./flyte/flytepropeller; make lint)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request housekeeping Issues that help maintain flyte and keep it tech-debt free size:XL This PR changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eapolinario @hamersaw